Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17745 )

Change subject: add http api, get version info
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc
File src/kudu/server/default_path_handlers.cc:

http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc@444
PS3, Line 444:                                             false, false);
> The webserver root handler (see server/webserver.cc) also has a "version_in
It'd be great if you could comment back mentioning your use case for this, 
given there are a few ways already to get this info. Those kinds of details 
would certainly help if included in the commit message.



--
To view, visit http://gerrit.cloudera.org:8080/17745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic25b08b3d3f9bb74e2a877c733ffcaf45f5ece46
Gerrit-Change-Number: 17745
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Tue, 24 Aug 2021 22:36:09 +0000
Gerrit-HasComments: Yes

Reply via email to