shenxingwuy...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17745 )
Change subject: [web-server] add http api, get version info ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17745/2/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/17745/2/src/kudu/server/default_path_handlers.cc@219 PS2, Line 219: Webserver::PrerenderedWebResponse* resp) { > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc@444 PS3, Line 444: false, false); > We can get version info by CLI tools, via `kudu tserver/master list`, is it My situation faces to applications need some kudu function, that just support from some version. So it need a method to check when installing or upgrading. For Users(not opers), restful api is better. Users usually don't know the path of kudu. http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc@444 PS3, Line 444: false, false); > It'd be great if you could comment back mentioning your use case for this, ok, has change commit msgs http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc@444 PS3, Line 444: ); > Version Information have added an ut http://gerrit.cloudera.org:8080/#/c/17745/3/src/kudu/server/default_path_handlers.cc@444 PS3, Line 444: false, false); > The webserver root handler (see server/webserver.cc) also has a "version_in Applications may need some kudu function, that just support from some version. So it need a method to check when installing or upgrading. Of course, footer has included the infomation, but it's not convenience for users. So this cr just like a syntax sugar. curl http://x.x.x.x:8050/version will directly return json, that's convenience. -- To view, visit http://gerrit.cloudera.org:8080/17745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic25b08b3d3f9bb74e2a877c733ffcaf45f5ece46 Gerrit-Change-Number: 17745 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <shenxingwuy...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <shenxingwuy...@gmail.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Wed, 25 Aug 2021 06:28:41 +0000 Gerrit-HasComments: Yes
