Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 16: (9 comments) http://gerrit.cloudera.org:8080/#/c/17725/16/src/kudu/server/server_base.h File src/kudu/server/server_base.h: http://gerrit.cloudera.org:8080/#/c/17725/16/src/kudu/server/server_base.h@269 PS16, Line 269: mutable > nit: I guess 'mutable' isn't needed here since the methods which acquire th Done http://gerrit.cloudera.org:8080/#/c/17725/16/src/kudu/server/server_base.h@271 PS16, Line 271: it's important that this is the first member to be destructed > style: to keep this comment easier to follow in the future modifications, p Done http://gerrit.cloudera.org:8080/#/c/17725/16/src/kudu/server/server_base.h@275 PS16, Line 275: DISALLOW_COPY_AND_ASSIGN(ServerBase); > nit: for better readability, prefer to keep this in the very end of the cla Done http://gerrit.cloudera.org:8080/#/c/17725/16/src/kudu/server/server_base.h@290 PS16, Line 290: > nit: extra spaces Done http://gerrit.cloudera.org:8080/#/c/17725/14/src/kudu/server/server_base.h File src/kudu/server/server_base.h: http://gerrit.cloudera.org:8080/#/c/17725/14/src/kudu/server/server_base.h@195 PS14, Line 195: : int64_t wal_dir_available_space_; : int64_t data_dirs_available_space_; : MonoTime wal_dir_space_last_check_; > Why not to move this into the private section to be along with the 'lock_' Done http://gerrit.cloudera.org:8080/#/c/17725/14/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/14/src/kudu/server/server_base.cc@919 PS14, Line 919: achToLastValue(&metric_d > I was going to point out that we need to take the lock before returning thi Done http://gerrit.cloudera.org:8080/#/c/17725/14/src/kudu/server/server_base.cc@953 PS14, Line 953: if (MonoTime::Now() < wal_dir_space_last_check_ + MonoDelta::FromSeconds( : FLAGS_fs_wal_dir_available_space_cache_seconds > We also need to hold the lock here. Consider early returning when possible Done http://gerrit.cloudera.org:8080/#/c/17725/14/src/kudu/server/server_base.cc@958 PS14, Line 958: ( > nit: small spacing alignment Done http://gerrit.cloudera.org:8080/#/c/17725/15/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/15/src/kudu/server/server_base.cc@972 PS15, Line 972: dat > data_dir Done -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 16 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 31 Aug 2021 01:13:17 +0000 Gerrit-HasComments: Yes
