Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... KUDU-3204: Add a metric for amount of available space This commit adds two metrics to server entity. - wal_dir_space_available_bytes - Exposes the free space available in the wal directory - data_dirs_space_available_bytes - Exposes the sum of free space in each of the data directories. We ensure the reserved space is being accounted for. This is specified by the flags --fs_data_dirs_reserved_bytes and --fs_wal_dir_reserved_bytes in data directories and wal directories respectively. For calculating the total free space in data directories, we ensure we are not counting the same device/filesystem twice by getting and checking for uniqueness of the filesystemID of each of the data directories before summing it up. Tested the uniqueness of the filesystemID by creating a new volume in my local macOS machine. The space reported is based on the data directories in different volumes (and hence unique filesystemID). Having multiple data directories on the same volume does not increase the metric. The free space calculated is cached for the period specified by the flags --fs_data_dirs_available_space_cache_seconds and --fs_wal_dir_available_space_cache_seconds. Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Reviewed-on: http://gerrit.cloudera.org:8080/17725 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/consensus/log.cc M src/kudu/fs/data_dirs.cc M src/kudu/fs/fs_manager.cc M src/kudu/integration-tests/disk_failure-itest.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/util/env.h M src/kudu/util/env_posix.cc 8 files changed, 191 insertions(+), 10 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 18 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
