Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17837 )
Change subject: [fs] Add limit for log block container metadata ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17837/3/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17837/3/src/kudu/fs/log_block_manager-test.cc@1186 PS3, Line 1186: 400 * 42 nit: it would be nice to add comment explaining the logic behind this size -- what do 400 and 42 correspond to given create_some_blocks' implementation and the format of the writable block? -- To view, visit http://gerrit.cloudera.org:8080/17837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12513abf2e45f7bdf091142c31f50d650b6f0cfc Gerrit-Change-Number: 17837 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 09 Sep 2021 21:57:46 +0000 Gerrit-HasComments: Yes
