Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17837 )
Change subject: KUDU-3318 [fs] Add size limit for log block container metadata ...................................................................... Patch Set 7: Code-Review+1 (6 comments) Thank you for addressing the feedback! We are almost there: just a few nits left in the commit's description. http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG@11 PS7, Line 11: cause because http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG@11 PS7, Line 11: LBM will reclaim : container files (.data and .metadata) when the container is : full (reach .data file offset limitation, or reach block number : limitation) and no live blocks left. Before reaching the reclaim : condition the metadata file will continuous consume disk space. How about: LBM reclaims both .data and corresponding .metadata container files when the .data container file becomes full (i.e. reaches its size or block count threshold). So, the .metadata container file might grow without any limit before the .data container becomes full. http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG@16 PS7, Line 16: add adds http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG@16 PS7, Line 16: to for http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG@17 PS7, Line 17: make it more easy to reach container's 'full' condition, taking it into account while determining the container's 'full' condition. http://gerrit.cloudera.org:8080/#/c/17837/7//COMMIT_MSG@17 PS7, Line 17: and : then more opportunity to be reclaimed, to avoid wasting too much : disk space. That gives the LBM an opportunity to reclaim the disk space once the container becomes full. -- To view, visit http://gerrit.cloudera.org:8080/17837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12513abf2e45f7bdf091142c31f50d650b6f0cfc Gerrit-Change-Number: 17837 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 11 Sep 2021 05:12:12 +0000 Gerrit-HasComments: Yes
