Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17837 )
Change subject: KUDU-3318 [fs] Add size limit for log block container metadata ...................................................................... Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17837/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17837/8//COMMIT_MSG@17 PS8, Line 17: This patch adds a size limit for log block container's metadata, : taking it into account while determining the container's 'full' : condition. That gives the LBM an opportunity to reclaim the disk : space once the container becomes full. So the hope in setting this limit is that it's more likely that a container will become full and fully deleted if we apply some limits to the size of metadata, compared to if we let a container grow its metadata unbounded. In those cases, the container can be completely removed. If the containers don't become fully deleted, we may just end up with more containers. It seems like a tricky balance to hit, but I see why this may still be useful. Longer term, I think the right approach here is to implement container metadata compaction/cleanup, either in the background or when a container becomes (or is near becoming) full. -- To view, visit http://gerrit.cloudera.org:8080/17837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12513abf2e45f7bdf091142c31f50d650b6f0cfc Gerrit-Change-Number: 17837 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 13 Sep 2021 17:00:19 +0000 Gerrit-HasComments: Yes
