Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17845 )
Change subject: [fs] Refactor fs module ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17845/1/src/kudu/fs/fs_report.cc File src/kudu/fs/fs_report.cc: http://gerrit.cloudera.org:8080/#/c/17845/1/src/kudu/fs/fs_report.cc@126 PS1, Line 126: int64_t full_container_space_count_repaired = 0; : int64_t full_container_space_bytes_repaired = 0; : int64_t full_container_space_bytes = 0; nit: Probably we can have the same order of initialization for orphaned_blocks* (above in line 91-93) and full_container_space* for uniformity? -- To view, visit http://gerrit.cloudera.org:8080/17845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa45637494b36cc1f4f00affdf995a25eb6231bc Gerrit-Change-Number: 17845 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 15 Sep 2021 15:38:57 +0000 Gerrit-HasComments: Yes
