Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17845 )
Change subject: [fs] Refactor fs module ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17845/1/src/kudu/fs/fs_report.cc File src/kudu/fs/fs_report.cc: http://gerrit.cloudera.org:8080/#/c/17845/1/src/kudu/fs/fs_report.cc@42 PS1, Line 42: MERGE_ENTRIE > If you are OK with the smell of this macro relying on the naming of 'entrie This macro is more or less like a member function of current structure, so I think access this structure's member variable 'entries' is not needed to pass as parameter. :) -- To view, visit http://gerrit.cloudera.org:8080/17845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa45637494b36cc1f4f00affdf995a25eb6231bc Gerrit-Change-Number: 17845 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 16 Sep 2021 02:52:05 +0000 Gerrit-HasComments: Yes
