Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17839 )
Change subject: [rpc] KUDU-75: refresh DNS entries if proxies hit a network error ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc File src/kudu/rpc/proxy-test.cc: http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc@77 PS6, Line 77: TestProxyReturnsOnNonTransientError nit: how long does it take to run this scenario? Should it be run only when KUDU_ALLOW_SLOW_TESTS env variable is defined? http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc@101 PS6, Line 101: HostPort Just to make sure my understanding is correct: that's the port part which is fake, not the IP address, right? http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc@102 PS6, Line 102: should still go through Could you please extend the comment explaining that the crux here is supplying valid address to Proxy::Init() below, DNS resolver isn't used at all in this case? http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc@106 PS6, Line 106: Proxy p(client_messenger, kFakeHostPort, &dns_resolver, : CalculatorService::static_service_name()); : p.Init(server_addr); Does it make sense to add a testcase to cover this situation of address supplied to Proxy::Init() when a different constructor is used to create an instance of Proxy? I guess we want to make explicit whether it's a valid usage for the Proxy::Init(addr) method (i.e. whether it succeeds at all) when the address specified in the constructor as well. http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy.cc File src/kudu/rpc/proxy.cc: http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy.cc@103 PS6, Line 103: if (!dns_resolver_) { : return; : } Should we return non-OK status here if the object was constructed with the Proxy::Proxy(std::shared_ptr<Messenger>, const Sockaddr&, string hostname, string service_name) constructor? -- To view, visit http://gerrit.cloudera.org:8080/17839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777d169bd3a461294e5721f05071b726ced70f7e Gerrit-Change-Number: 17839 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 20 Sep 2021 19:35:14 +0000 Gerrit-HasComments: Yes
