Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17839 )
Change subject: [rpc] KUDU-75: refresh DNS entries if proxies hit a network error ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc File src/kudu/rpc/proxy-test.cc: http://gerrit.cloudera.org:8080/#/c/17839/6/src/kudu/rpc/proxy-test.cc@106 PS6, Line 106: // still go through since we call Init() with a valid address. : shared_ptr<Messenger> client_messenger; : ASSERT_OK(CreateMess > Done Thank you! http://gerrit.cloudera.org:8080/#/c/17839/8/src/kudu/rpc/proxy.h File src/kudu/rpc/proxy.h: http://gerrit.cloudera.org:8080/#/c/17839/8/src/kudu/rpc/proxy.h@81 PS8, Line 81: // If the proxy is configured for address re-resolution (by supplying a Thank you for updating the comment! -- To view, visit http://gerrit.cloudera.org:8080/17839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777d169bd3a461294e5721f05071b726ced70f7e Gerrit-Change-Number: 17839 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 21 Sep 2021 21:43:58 +0000 Gerrit-HasComments: Yes
