Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17868 )
Change subject: [consensus] KUDU-1620: re-resolve consensus peers on network error ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17868/3/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/17868/3/src/kudu/consensus/consensus_peers.cc@585 PS3, Line 585: CreateConsensusServiceProxyForHost > SetPermanentUuidForRemotePeer() retries until success, up to a timeout. Thi Yup, my question stemmed from the fact that ConsensusServiceProxy::Init() wouldn't return an indication of a failure, and I forgot about new provisions in Proxy::AsyncRequest(). Thank you for adding the test! http://gerrit.cloudera.org:8080/#/c/17868/5/src/kudu/integration-tests/dns_alias-itest.cc File src/kudu/integration-tests/dns_alias-itest.cc: http://gerrit.cloudera.org:8080/#/c/17868/5/src/kudu/integration-tests/dns_alias-itest.cc@138 PS5, Line 138: daemon->mutable_flags()->emplace_back("--webserver_enabled=false"); nit: would it be cleaner to explicitly add this flag into the cluster options in as a part of SetUp() method? -- To view, visit http://gerrit.cloudera.org:8080/17868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1b68c3c14d7d8f81168e16fe450d2ffcce840b Gerrit-Change-Number: 17868 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 07 Oct 2021 23:59:24 +0000 Gerrit-HasComments: Yes
