Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17868 )
Change subject: [consensus] KUDU-1620: re-resolve consensus peers on network error ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17868/5/src/kudu/integration-tests/dns_alias-itest.cc File src/kudu/integration-tests/dns_alias-itest.cc: http://gerrit.cloudera.org:8080/#/c/17868/5/src/kudu/integration-tests/dns_alias-itest.cc@138 PS5, Line 138: daemon->mutable_flags()->emplace_back("--webserver_enabled=false"); > nit: would it be cleaner to explicitly add this flag into the cluster optio Sure, I did this in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/17868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1b68c3c14d7d8f81168e16fe450d2ffcce840b Gerrit-Change-Number: 17868 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 08 Oct 2021 00:18:43 +0000 Gerrit-HasComments: Yes
