Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 )
Change subject: KUDU-3318 [LBM] Runtime compact log container metadata ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc@208 PS3, Line 208: enabli > nit: "when enabling" Done http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc@576 PS3, Line 576: // Try lock before reading metadata offset, consider it not full if lock failed. : if (!metadata_lock_.try_lock()) { : return false; : } > Does this mean that if a metadata file is getting written to a lot, we may Yes, it will cause metadata exceed it's size limitation, but it's not a serious issue, we consider it's just a soft limit. http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc@621 PS3, Line 621: bool ShouldCompact() const { > nit: maybe call this ShouldCompact()? Done http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc@628 PS3, Line 628: if (static_ > nit: typically when we need both a locked and an unlocked version, that tak Done http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc@864 PS3, Line 864: vector<BlockRecordPB> records = SortRecords(live_block_records); > In the event of a disk failure, rather than crashing, perhaps we should set Good, we can use SetReadOnly in this case. http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager.cc@2632 PS3, Line 2632: arbage at startup time (in the event that we crashed just before the > Rather than looking up the container reference, could we use scoped_refptr< Done -- To view, visit http://gerrit.cloudera.org:8080/17871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72bdf73fa73403918c01dfa9d45530fad47ecaf6 Gerrit-Change-Number: 17871 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 11 Oct 2021 08:12:21 +0000 Gerrit-HasComments: Yes
