Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17871 )
Change subject: KUDU-3318 [LBM] Runtime compact log container metadata ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17871/3//COMMIT_MSG Commit Message: PS3: > Didn't try on cluster yet, I will do more test next Cool, looking forward to seeing if it helps! I also wonder whether this will help reduce startup times at all, since mostly-deleted containers will require fewer cycles to read through when starting up. http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager-test.cc@1253 PS3, Line 1253: 1 << 15; nit: prefer to be more explicit with these values (e.g. 32 * 1024), optimizing tests for readability over micro-optimizations likes this http://gerrit.cloudera.org:8080/#/c/17871/3/src/kudu/fs/log_block_manager-test.cc@1254 PS3, Line 1254: mt_create_and_delete_blocks(); nit: wrap in NO_FATALS() so the error messages point to this line number if it fails. Same elsewhere http://gerrit.cloudera.org:8080/#/c/17871/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17871/5/src/kudu/fs/log_block_manager.cc@864 PS5, Line 864: live_block_records We should std::move() this to avoid a copy. http://gerrit.cloudera.org:8080/#/c/17871/5/src/kudu/fs/log_block_manager.cc@2812 PS5, Line 2812: vector<BlockRecordPB> records = LogBlockContainer::SortRecords(live_block_records); We should std::move() this to avoid a copy. -- To view, visit http://gerrit.cloudera.org:8080/17871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72bdf73fa73403918c01dfa9d45530fad47ecaf6 Gerrit-Change-Number: 17871 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 11 Oct 2021 21:31:40 +0000 Gerrit-HasComments: Yes
