Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/17730/18/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/17730/18/src/kudu/tserver/ts_tablet_manager.cc@1351 PS18, Line 1351: : int elapsed_ms = (MonoTime::Now() - start).ToMilliseconds(); : if (elapsed_ms > FLAGS_tablet_start_warn_threshold_ms) { : LOG(WARNING) << LogPrefix(tablet_id) << "Tablet startup took " << elapsed_ms << "ms"; : if (Trace::CurrentTrace()) { : LOG(WARNING) << LogPrefix(tablet_id) << "Trace:" << std::endl : << Trace::CurrentTrace()->DumpToString(); : } : } : UpdateStartupProgress((tablets_total != nullptr) ? tablets_total->load() : 0, : > Done Just realized, we the member variables to be accessed in the metrics patch. Hence adding it back to where it was in the next revision of this patch -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 19 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 11 Oct 2021 18:01:50 +0000 Gerrit-HasComments: Yes
