Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/17730/20/src/kudu/util/timer.h File src/kudu/util/timer.h: http://gerrit.cloudera.org:8080/#/c/17730/20/src/kudu/util/timer.h@43 PS20, Line 43: DCHECK(start_time_ != MonoTime::Min()); > For DCHECK_NE, appears we need to implement the operator operator<<(ostream Also placed the DCHECK under the lock for now. Should be reflecting in patchset-22 -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 21 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 19 Oct 2021 04:07:01 +0000 Gerrit-HasComments: Yes
