Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17972 )
Change subject: [client] fix recently introduced ABI compatiblity issue ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Slightly lean towards renaming "stat" to "info", given stats typically summarize a lot of data, and the info we're showing is more than just a summarization of large data volumes. Don't feel strongly about it though. http://gerrit.cloudera.org:8080/#/c/17972/2/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/17972/2/src/kudu/client/client-internal.cc@438 PS2, Line 438: vector<TableStats>* tables_stats, Yeah, I guess if we wanted an exported version of this, we could add to KuduTableStatistics. Maybe we should in the future, or consider renaming this to TableInfo as it was, to avoid conflating the two (I don't feel strongly about it though). -- To view, visit http://gerrit.cloudera.org:8080/17972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I214d424eb0e91b90db813fde0e0b7150253bca91 Gerrit-Change-Number: 17972 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Tue, 26 Oct 2021 20:19:25 +0000 Gerrit-HasComments: Yes
