Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17972 )
Change subject: [client] fix recently introduced ABI compatiblity issue ...................................................................... [client] fix recently introduced ABI compatiblity issue This patch fixes the recently introduced ABI compatibility issue in Kudu C++ client once the KuduClient::ListTables() method was overloaded (see [1] for details). As I could see, the overloaded method was only used in the Kudu CLI tooling with no apparent justification why it's needed in the public client API. With that, I moved the method to be a part of the KuduClient::Data internal class. In addition, I renamed --list_statistics into --show_table_info for the `kudu table list` CLI tool and switched to the lower_camel_case for the tags used to output a table's stats. This is a follow-up to 3ccc434ea6dcbef15a12bd1734c8e66b69a611c5. [1] https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B Change-Id: I214d424eb0e91b90db813fde0e0b7150253bca91 Reviewed-on: http://gerrit.cloudera.org:8080/17972 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_table.cc 6 files changed, 88 insertions(+), 104 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I214d424eb0e91b90db813fde0e0b7150253bca91 Gerrit-Change-Number: 17972 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: yejiabao <yejia...@huawei.com>
