Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [encryption] KUDU-3331 Encrypt file system ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/17974/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17974/2//COMMIT_MSG@12 PS2, Line 12: ntegrates this encryption support into the project > nit: does it make sense to mention that there is at least one TODO to prope Done http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG@15 PS3, Line 15: I also changed the way the "encrypted" flag in *FileOptions works: > nit: maybe it's worth calling this "is_sensitive" to avoid confusion Done http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG@20 PS3, Line 20: not having to complicate : FileCache. > Could you elaborate on this a bit more -- what would go wrong if we left th Are you suggesting that the file cache would still only support encrypted files, but it would be set inside the file cache instead of in env? I guess that wouldn't introduce much more complextity. http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG@28 PS3, Line 28: we can keep FileCache simpler as it doesn't : have to > nit: I'm having trouble parsing this sentence. Mind rephrasing? I'm guessin Yep, this must have been an editing error. http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG@32 PS3, Line 32: and tablet metadata files. > Why is this the case again? There's a lot you can infer from just a tablet So far, we haven't treated this metadata as sensitive (e.g. when you run wal dump -redact=all, table schema info is still shown. -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Nov 2021 15:16:32 +0000 Gerrit-HasComments: Yes
