Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [encryption] KUDU-3331 Encrypt file system ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17974/3//COMMIT_MSG@19 PS3, Line 19: The default is : now true > I'm working on fixing this stuff. | Can you elaborate on this? I'm not sure I understand. The idea was to have a way to validate the resulting files under the kudu-master and kudu-tserver directories after running those processes with --enable_encryption flag set. Basically, that's about making sure that different types of files are encrypted or non-encrypted as expected (think of some sort of checklist). Not sure what's the best way of doing that in our test framework, though. After thinking about this a bit more, I guess it's just enough to validate that once manually given that the code regarding encrypting/non-encrypting particular types of files isn't supposed to change often. -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 03 Nov 2021 16:04:22 +0000 Gerrit-HasComments: Yes
