Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 )
Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2151 PS2, Line 2151: CHECK_OK(repair_pool->Submit([this, dd_raw, dr]() { this->RepairTask(dd_raw, dr); })); > Exactly. However, RepairTask are run on the dir's thread pool anyways, rig Ah, wait -- it seems I misunderstood this, sorry. By adding the new repair tool the actual work of doing some preparatory work before rewriting tablet's metadata is now done on the threads of the new thread pool. For some reason, I assumed (probably because gerrit was showing me just a part of the Repair() method) the whole Repair() method is run on the dir's thread pool even after introducing the extra pool, but that's not exactly so. Also, it seems dd->ExecClosure() isn't going to block and run on the calling thread since the data dir's pool has the queue of unlimited capacity (up to INT_MAX tasks can be scheduled): https://github.com/apache/kudu/blob/3e24e1be4362ba9efb6d295ff96d3a18893f2733/src/kudu/fs/dir_manager.cc#L568-L573 -- To view, visit http://gerrit.cloudera.org:8080/17942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5 Gerrit-Change-Number: 17942 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 03 Nov 2021 20:27:56 +0000 Gerrit-HasComments: Yes
