Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17942 )

Change subject: [LBM] Speed up server bootstrap by using multi-thread to 
compact containers
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17942/5/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/17942/5/src/kudu/fs/log_block_manager.cc@131
PS5, Line 131: Amount of latency in ms to inject when rewrite metadata file. "
             :              "Only for testing
> nit: this is marked as done, but I don't see the update.  Is it planned to
Sorry, I forget to push :(


http://gerrit.cloudera.org:8080/#/c/17942/5/src/kudu/fs/log_block_manager.cc@133
PS5, Line 133: TAG_FLAG(log_container_metadata_rewrite_inject_latency_ms, 
hidden);
> nit: I guess this tag isn't necessary since the flag is already hidden
Done



--
To view, visit http://gerrit.cloudera.org:8080/17942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5
Gerrit-Change-Number: 17942
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Greg Solovyev <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 03 Nov 2021 11:41:56 +0000
Gerrit-HasComments: Yes

Reply via email to