Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17990 )
Change subject: KUDU-1959 - Implement tests for the startup progress page for tablet servers ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17990/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17990/3//COMMIT_MSG@7 PS3, Line 7: KUDU-1959 - Implement tests for the startup progress page for tablet servers This is 76 characters which seems a bit too long. Generally, we wrap lines in the body at 72 characters (except for log messages, etc), and try to keep the subjects even shorter, preferably at 50, but that is often impossible. Still, please consider rephrasing and reformatting this (e.g. "KUDU-1959 Add tests for /startup page in tservers" is 49 characters). The subject of a commit message is similar to the subject of an email, the goal is to provide a very brief summary so that the reader knows what it's about at a first glance. http://gerrit.cloudera.org:8080/#/c/17990/3/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: PS3: Some of the concerns raised in the parent apply here as well. http://gerrit.cloudera.org:8080/#/c/17990/3/src/kudu/tserver/tablet_server-test.cc@784 PS3, Line 784: /*num_data_dirs=*/ nit: no need for this as you're using a constant which describes what this parameter is. -- To view, visit http://gerrit.cloudera.org:8080/17990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f432b4eb813e51214b4d6b3c5b7b4c89426f47f Gerrit-Change-Number: 17990 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 05 Nov 2021 09:42:54 +0000 Gerrit-HasComments: Yes
