Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17990 )
Change subject: KUDU-1959 - Add tests for /startup page and metrics for tservers ...................................................................... Patch Set 8: Code-Review+1 (6 comments) Overall looks good, just some style nits. Also the lint build seems to be complaining. http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc@793 PS8, Line 793: g & nit: move the ampersand over, same below http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc@798 PS8, Line 798: nit: align spaces http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc@829 PS8, Line 829: string addr = mini_server_->bound_http_addr().ToString(); nit: seems like this is only used in the context of the full URL. How about we instead define this as const string url = Substitute("http://$0/startup";, mini_server_->bound_http_addr().ToString()); http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc@833 PS8, Line 833: strings nit: there is a using directive for this, so we can drop the "strings::" http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc@852 PS8, Line 852: ( nit: can drop this outer parentheses http://gerrit.cloudera.org:8080/#/c/17990/8/src/kudu/tserver/tablet_server-test.cc@896 PS8, Line 896: string addr = mini_server_->bound_http_addr().ToString(); nit: same here w.r.t the URL -- To view, visit http://gerrit.cloudera.org:8080/17990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f432b4eb813e51214b4d6b3c5b7b4c89426f47f Gerrit-Change-Number: 17990 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 11 Nov 2021 01:30:33 +0000 Gerrit-HasComments: Yes
