Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18000/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18000/1//COMMIT_MSG@30 PS1, Line 30: [1] https://stackoverflow.com/questions/29960871/protobuf-message-object-creation-by-name > nit: maybe link to the answer specifically: https://stackoverflow.com/a/148 I added the link to the GNU ld manual page which explains how the --exclude-libs options works. The SO article's link about using --exclude-libs is already present in KUDU-3334. http://gerrit.cloudera.org:8080/#/c/18000/1/src/kudu/client/CMakeLists.txt File src/kudu/client/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18000/1/src/kudu/client/CMakeLists.txt@143 PS1, Line 143: version-script option > can you add that it doesn't support exclude-libs either? Done -- To view, visit http://gerrit.cloudera.org:8080/18000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee Gerrit-Change-Number: 18000 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 05 Nov 2021 16:11:58 +0000 Gerrit-HasComments: Yes
