Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18000/3/src/kudu/client/CMakeLists.txt File src/kudu/client/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18000/3/src/kudu/client/CMakeLists.txt@145 PS3, Line 145: set(LINK_FLAGS "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map,--exclude-libs=libprotobuf") nit: this line is now too long -- To view, visit http://gerrit.cloudera.org:8080/18000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee Gerrit-Change-Number: 18000 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 05 Nov 2021 17:20:58 +0000 Gerrit-HasComments: Yes
