Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18018 )
Change subject: [build] Introduce an env variable to indicate the thirdparty path ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18018/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/18018/2/build-support/jenkins/build-and-test.sh@314 PS2, Line 314: : if [ ! -n "${THIRDPARTY_DIR}" ]; then : THIRDPARTY_DIR=$SOURCE_ROOT/thirdparty : fi > nit: consider using the same syntax used elsewhere? Same in other files, if +1 -- To view, visit http://gerrit.cloudera.org:8080/18018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0bdf4faa44322622c48cacadf8e1165eccd38a Gerrit-Change-Number: 18018 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 12 Nov 2021 21:00:28 +0000 Gerrit-HasComments: Yes
