Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18018 )
Change subject: [build] Introduce an env variable to indicate the thirdparty path ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18018/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18018/2//COMMIT_MSG@15 PS2, Line 15: - Build an docker image with thirdparty libraries well built, then we > I'd discussed this with Grant when he contributed the Docker deployments. I I agree not to provide thirdparty images on DockerHub, but I think provide a DockerFile to build such a image is reasonable, although the images will be outdated when thirdparties changes, but thirdparties are not changed frequently. Yes, cache is a way to reduce building time in CI/CD pipeline, but it's not the only use case. http://gerrit.cloudera.org:8080/#/c/18018/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/18018/2/build-support/jenkins/build-and-test.sh@314 PS2, Line 314: THIRDPARTY_TYPE=tsan : fi : : if > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/18018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0bdf4faa44322622c48cacadf8e1165eccd38a Gerrit-Change-Number: 18018 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 13 Nov 2021 05:00:46 +0000 Gerrit-HasComments: Yes
