Hello Mahesh Reddy, Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18024
to look at the new patch set (#2).
Change subject: [client] fix MetaCacheEntry::Contains()
......................................................................
[client] fix MetaCacheEntry::Contains()
It seems that while working on a50091e2d, I went too far with
back-porting changes from the revamped code and used the unabridged
MetaCacheEntry::Contains() implementation from the new approach. That
turned to be problematic if still using the legacy way of comparing
partition keys for tables using only hash partitioning.
This patch returns the legacy implementation of the
MetaCacheEntry::Contains() method back and adds a couple of stress
test scenarios for the C++ client's metacache. Before reverting to
the legacy implementation of the MetaCacheEntry::Contains() method,
both Perf and PerfSynthetic test scenarios were failing because
KuduDeleteIgnore operations would timeout since MetaCache was endlessly
fetching information on particular PartitionKeys again and again when
MetaCacheEntry::Contains() returned 'false' instead of returning 'true'.
This is a follow-up to a50091e2d4509feac2f29128107102ec52fcb7b0.
Change-Id: I7f2deeefbf2e3cedc7654b5d977382501db14b4e
---
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/integration-tests/client-stress-test.cc
4 files changed, 166 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/18024/2
--
To view, visit http://gerrit.cloudera.org:8080/18024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f2deeefbf2e3cedc7654b5d977382501db14b4e
Gerrit-Change-Number: 18024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
