Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18024 )
Change subject: [client] fix MetaCacheEntry::Contains() ...................................................................... Patch Set 2: Code-Review+2 (3 comments) LGTM, though it's also worth getting a look from Mahesh. http://gerrit.cloudera.org:8080/#/c/18024/2/src/kudu/integration-tests/client-stress-test.cc File src/kudu/integration-tests/client-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/18024/2/src/kudu/integration-tests/client-stress-test.cc@379 PS2, Line 379: unique_ptr<KuduDeleteIgnore> op(table_->NewDeleteIgnore()); Clever! http://gerrit.cloudera.org:8080/#/c/18024/2/src/kudu/integration-tests/client-stress-test.cc@441 PS2, Line 441: vector<unique_ptr<KuduDeleteIgnore>> ops; : ops.reserve(kNumRows); : { : for (int32_t idx = 0; idx < kNumRows; ++idx) { : unique_ptr<KuduDeleteIgnore> op(table_->NewDeleteIgnore()); : ASSERT_OK(op->mutable_row()->SetInt64(0, idx)); : ASSERT_OK(op->mutable_row()->SetString(1, : std::to_string(idx) + string(1, static_cast<char>(idx % 128)))); : ops.emplace_back(std::move(op)); : } : } nit: consider an anonymous function to share across these tests http://gerrit.cloudera.org:8080/#/c/18024/2/src/kudu/integration-tests/client-stress-test.cc@462 PS2, Line 462: client::sp::shared_ptr<KuduSession> session(client_->NewSession()); : ASSERT_OK(session->SetFlushMode(KuduSession::MANUAL_FLUSH)); : ASSERT_OK(session->SetMutationBufferSpace(64 * 1024 * 1024)); nit: are we intentionally timing these too? if not, consider moving it out of the timed block -- To view, visit http://gerrit.cloudera.org:8080/18024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f2deeefbf2e3cedc7654b5d977382501db14b4e Gerrit-Change-Number: 18024 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 13 Nov 2021 03:24:18 +0000 Gerrit-HasComments: Yes
