Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18024 )
Change subject: [client] fix MetaCacheEntry::Contains() ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18024/3/src/kudu/integration-tests/client-stress-test.cc File src/kudu/integration-tests/client-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/18024/3/src/kudu/integration-tests/client-stress-test.cc@337 PS3, Line 337: #if !defined(THREAD_SANITIZER) && !defined(ADDRESS_SANITIZER) > I'm not sure it makes a lot of sense to always call GTEST_SKIP in ASAN and I think there are examples for both approaches in our codebase. Anyway, I don't feel strongly about it, just thought it might be more developer friendly to see these tests are skipped. -- To view, visit http://gerrit.cloudera.org:8080/18024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f2deeefbf2e3cedc7654b5d977382501db14b4e Gerrit-Change-Number: 18024 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 15 Nov 2021 18:26:59 +0000 Gerrit-HasComments: Yes
