Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17990 )
Change subject: KUDU-1959 - Add tests for /startup page and metrics for tservers ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17990/12/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/17990/12/src/kudu/tserver/tablet_server-test.cc@851 PS12, Line 851: SleepFor(MonoDelta::FromMilliseconds(10)); We chatted about this offline. Seems like this delay is added to test around a real race that is happening in the webserver, where we're receiving a request as the templates are being registered. We should instead address the race -- To view, visit http://gerrit.cloudera.org:8080/17990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f432b4eb813e51214b4d6b3c5b7b4c89426f47f Gerrit-Change-Number: 17990 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 16 Nov 2021 19:36:04 +0000 Gerrit-HasComments: Yes
