Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18055 )
Change subject: [dense_node-itest] enable on macOS ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/CMakeLists.txt@155 PS1, Line 155: # Opens too many files on macOS because we're not using a file cache for : # reading log segments. : # TODO(wdb): Re-enable once a file cache is being used. nit: should this piece be removed as well? http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/dense_node-itest.cc File src/kudu/integration-tests/dense_node-itest.cc: http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/dense_node-itest.cc@119 PS1, Line 119: // Compactions aim to reduce the number of rowsets and thus reduce the : // number of cfiles. Disable it so we can maximize the number of files. : "--enable_rowset_compaction=false", This test scenario is run as part of src/kudu/scripts/benchmarks.sh. Should we expect this to change the micro-benchmark numbers? http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/dense_node-itest.cc@189 PS1, Line 189: if (FLAGS_block_manager == "log") { : metric_prototypes = { &METRIC_log_block_manager_blocks_under_management, : &METRIC_log_block_manager_bytes_under_management, : &METRIC_log_block_manager_containers, : &METRIC_log_block_manager_full_containers, : &METRIC_threads_running }; : } else { : metric_prototypes = { &METRIC_block_manager_total_bytes_written, : &METRIC_block_manager_total_blocks_created, : &METRIC_threads_running }; : } While you are here, do you think the block_manager_total_disk_sync metric looks interesting as well? -- To view, visit http://gerrit.cloudera.org:8080/18055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I240331c4c9293d4f449d52b6a4ed2392a6ec9f3c Gerrit-Change-Number: 18055 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 29 Nov 2021 18:23:34 +0000 Gerrit-HasComments: Yes
