Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18055 )
Change subject: [dense_node-itest] enable on macOS ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/CMakeLists.txt@155 PS1, Line 155: endif() : : # Tests that should not be run automatically by ctest. > nit: should this piece be removed as well? Done http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/dense_node-itest.cc File src/kudu/integration-tests/dense_node-itest.cc: http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/dense_node-itest.cc@119 PS1, Line 119: "--enable_undo_delta_block_gc=false", : : // Compactions aim to reduce the nu > This test scenario is run as part of src/kudu/scripts/benchmarks.sh. Shoul Good point -- we would. I don't think it makes a huge difference, so I'll leave this as an option for test runners to decide, and leave the default as is. http://gerrit.cloudera.org:8080/#/c/18055/1/src/kudu/integration-tests/dense_node-itest.cc@189 PS1, Line 189: // Collect some interesting metrics. The cluster is shut down before the : // metrics are logged so that they're easier to find in the log output. : vector<pair<string, int64_t>> metrics; : vector<GaugePrototype<uint64>*> metric_prototypes; : if (FLAGS_block_manager == "log") { : metric_prototypes = { &METRIC_log_block_manager_blocks_under_management, : &METRIC_log_block_manager_bytes_under_management, : &METRIC_log_block_manager_containers, : &METRIC_log_block_manager_full_containers, : &METRIC_block_manager_total_disk_sync, : > While you are here, do you think the block_manager_total_disk_sync metric l Done -- To view, visit http://gerrit.cloudera.org:8080/18055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I240331c4c9293d4f449d52b6a4ed2392a6ec9f3c Gerrit-Change-Number: 18055 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 29 Nov 2021 23:39:17 +0000 Gerrit-HasComments: Yes
