Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 )
Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...................................................................... Patch Set 1: (1 comment) Given this command will likely be used to recover numerous tablets after a disastrous event, before creating the cmeta file, would it be a good idea to check the tablet-meta to ensure the tablet indeed exists to avoid any accidents while executing the commands? http://gerrit.cloudera.org:8080/#/c/18029/1/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18029/1/src/kudu/tools/tool_action_local_replica.cc@389 PS1, Line 389: int64_t term = stoi(FindOrDie(context.required_args, "term")); : int64_t opid_index = stoi(FindOrDie(context.required_args, "index")); Since these both are integers which can be easily interchanged erroneously, do we want to add a check to ensure index is always grater or equal to term? -- To view, visit http://gerrit.cloudera.org:8080/18029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136cc5b5797420a9ca9156f37c3e281da0c265d7 Gerrit-Change-Number: 18029 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 30 Nov 2021 06:11:27 +0000 Gerrit-HasComments: Yes
