Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 )
Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18029/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS2: > Could you also add a test that creates a real tablet, deletes its cmeta, re Current tests don't use mini cluster, only fs manager. Do you think it's worth changing it to add this test case? http://gerrit.cloudera.org:8080/#/c/18029/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18029/2/src/kudu/tools/tool_action_local_replica.cc@417 PS2, Line 417: scoped_refptr<ConsensusMetadataManager> cmeta_manager(new ConsensusMetadataManager(&fs_manager)); > nit: could this be stack allocated? I already answered this here: https://gerrit.cloudera.org/c/18029/1/src/kudu/tools/tool_action_local_replica.cc#416 -- To view, visit http://gerrit.cloudera.org:8080/18029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136cc5b5797420a9ca9156f37c3e281da0c265d7 Gerrit-Change-Number: 18029 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 25 Jan 2022 23:06:55 +0000 Gerrit-HasComments: Yes
