Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18053 )

Change subject: [bootstrap] Speedup tablet bootstrap
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18053/4//COMMIT_MSG
Commit Message:

PS4:
Can you add some benchmarks before and after using a release build to the 
commit message?


http://gerrit.cloudera.org:8080/#/c/18053/4//COMMIT_MSG@11
PS4, Line 11: - short circuit return when found an active memory store in 
TabletBootstrap::AnalyzeActiveStores()
nit: wrap these at 80


http://gerrit.cloudera.org:8080/#/c/18053/4/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18053/4/src/kudu/tserver/ts_tablet_manager.cc@511
PS4, Line 511:         if (cur_loaded_count % 200 == 0) {
Does KLOG_EVERY_N/KLOG_EVERY_N_SECS not work here?



--
To view, visit http://gerrit.cloudera.org:8080/18053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I816417d2d4c24014edb6b2a40c060f29e37ae219
Gerrit-Change-Number: 18053
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 30 Nov 2021 23:46:24 +0000
Gerrit-HasComments: Yes

Reply via email to