Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18053 )
Change subject: [bootstrap] Speedup tablet bootstrap ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/18053/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18053/8//COMMIT_MSG@18 PS8, Line 18: --num_tablets_to_open_simultaneously=8 Can you show the actual numbers? Did you use the same num_tablets_to_open_simultaneously for both before and after your changes? http://gerrit.cloudera.org:8080/#/c/18053/8/src/kudu/tserver/ts_tablet_manager-test.cc File src/kudu/tserver/ts_tablet_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/18053/8/src/kudu/tserver/ts_tablet_manager-test.cc@416 PS8, Line 416: .set_max_threads(8) Why 8 threads specifically? http://gerrit.cloudera.org:8080/#/c/18053/8/src/kudu/tserver/ts_tablet_manager-test.cc@436 PS8, Line 436: FLAGS_tablet_bootstrap_skip_opening_tablet_for_testing = true; Why do we skip opening the tablet? Shouldn't we measure the time it takes to fully open the tablets? http://gerrit.cloudera.org:8080/#/c/18053/8/src/kudu/tserver/ts_tablet_manager-test.cc@437 PS8, Line 437: FLAGS_tablet_metadata_load_inject_latency_ms = 2; Why are we injecting latency in a benchmark? -- To view, visit http://gerrit.cloudera.org:8080/18053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I816417d2d4c24014edb6b2a40c060f29e37ae219 Gerrit-Change-Number: 18053 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 02 Dec 2021 08:28:37 +0000 Gerrit-HasComments: Yes
