Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18070 )
Change subject: [kudu-client] Shade stumbleupon async jar to kudu-client ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18070/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18070/1//COMMIT_MSG@7 PS1, Line 7: [kudu-client] Shade stumbleupon async jar to kudu-client nit: [java] would be a better tag http://gerrit.cloudera.org:8080/#/c/18070/1/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/18070/1/java/kudu-client/build.gradle@23 PS1, Line 23: // Shading stumbleupon async jar so that it's available for users of kudu-client Wouldn't this break third-party clients that depend on Kudu providing stumbleupon async? -- To view, visit http://gerrit.cloudera.org:8080/18070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a237b589bdd55061b660414b5b955ad73942af Gerrit-Change-Number: 18070 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 06 Dec 2021 14:55:09 +0000 Gerrit-HasComments: Yes
