Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18070 )
Change subject: [kudu-client] Shade stumbleupon async jar to kudu-client ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18070/1/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/18070/1/java/kudu-client/build.gradle@23 PS1, Line 23: // Shading stumbleupon async jar so that it's available for users of kudu-client > Wouldn't this break third-party clients that depend on Kudu providing stumb I'm not sure I understand the question. By third-party clients you mean clients that directly use the KRPC protocol? This dependency is specific to kudu Java client and earlier the dependent jar was not provided and now it'll come included with kudu java client. Taking it away would be problematic in this case we are explicitly supplying it. One downside could be if a client wants to use a different version of async jar. This jar hasn't been updated in almost 6 years and we are using the latest version. So chances of that causing issues is theoretically possible but unlikely. That being said, my experience with Java/Scala/Spark side of Kudu has been minimal so if there are genuine concerns then definitely we should think this through. -- To view, visit http://gerrit.cloudera.org:8080/18070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a237b589bdd55061b660414b5b955ad73942af Gerrit-Change-Number: 18070 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 06 Dec 2021 17:45:41 +0000 Gerrit-HasComments: Yes
