Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18090 )
Change subject: [consensus] reduce critical section in LogCache::ReadOps() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18090/1/src/kudu/consensus/log_cache.cc File src/kudu/consensus/log_cache.cc: http://gerrit.cloudera.org:8080/#/c/18090/1/src/kudu/consensus/log_cache.cc@348 PS1, Line 348: if (remaining_space < 0) { > Yup, that's the idea: once we do subtraction of the total message size belo It seems on of the tests relies on this exact logic, so I returned it back. Essentially, this does pre-check on whether we are about to get over the limit if adding an extra element (but we have to provide at least one element in the output). -- To view, visit http://gerrit.cloudera.org:8080/18090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7de32eb8adde242c8047720e062535cbdaf3e39 Gerrit-Change-Number: 18090 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Dec 2021 23:12:17 +0000 Gerrit-HasComments: Yes
