Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18090 )
Change subject: [consensus] reduce critical section in LogCache::ReadOps() ...................................................................... [consensus] reduce critical section in LogCache::ReadOps() This patch reduces the section protected by the lock in LogCache::ReadOps(), moving out of the critical section several operations which do not need such a protection. I didn't find an existing performance test which would exercise the updated code path, but reducing the time spent under a lock looks like an improvement. Change-Id: Ia7de32eb8adde242c8047720e062535cbdaf3e39 Reviewed-on: http://gerrit.cloudera.org:8080/18090 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/log_cache.cc 2 files changed, 20 insertions(+), 22 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/18090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia7de32eb8adde242c8047720e062535cbdaf3e39 Gerrit-Change-Number: 18090 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
