Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18112 )
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59 PS3, Line 59: "The minimal table schema version. When tserver " nit: maybe be more specific about what's going on here: "The table schema version assigned to tables if one cannot be determined automatically. When the tablet server version is < 1.6, a viable value can be determined manually using 'kudu pbc dump tablet-meta/<tablet-id>' on each server and taking the max value found across all tablets. In tablet server versions >= 1.6, Kudu will determine the proper value for each tablet automatically." Also, does this value need to be exact? Or is it viable to set an arbitrarily high value for this? http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59 PS3, Line 59: min nit: maybe call this "default_schema_version"? http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@60 PS3, Line 60: 1.6 Should this be 1.16? -- To view, visit http://gerrit.cloudera.org:8080/18112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7 Gerrit-Change-Number: 18112 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 23 Dec 2021 22:11:27 +0000 Gerrit-HasComments: Yes
