Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18112 )
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59 PS3, Line 59: 0, "The table schema version assigned to tables > nit: maybe be more specific about what's going on here: It's viable to set an arbitrarily high value. http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59 PS3, Line 59: def > nit: maybe call this "default_schema_version"? Done http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@60 PS3, Line 60: det > Should this be 1.16? Yes, 1.16.. -- To view, visit http://gerrit.cloudera.org:8080/18112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7 Gerrit-Change-Number: 18112 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 24 Dec 2021 06:35:41 +0000 Gerrit-HasComments: Yes
