Yifan Zhang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18116


Change subject: KUDU-3346: fix rebalancer tool fails to run with 
'--ignored_tservers'
......................................................................

KUDU-3346: fix rebalancer tool fails to run with '--ignored_tservers'

Prior to this patch the validity of 'ignored_tservers' was checked when
'BuildClusterinfo', which leads to a failure when the 'raw_info' only contains
contains information of tservers on a specific location. This patch fix it by
moving the parameter validity check into 'KsckResultsToClusterRawInfo', because
ksck results contain original cluster information.

I noticed 'ClusterInfo::tservers_to_empty' is not necessary to be built when
'BuildClusterInfo', because we use this info only for printing cluster's stats
and running IgnoredTserverRunner. This should be refactored in follow-up patch.

This patch adds a regression test for the issue and I also verified this fix on
a real cluster.

Change-Id: Ie75e246f924fe96d1d8f0f0a54511c810851f56c
---
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
4 files changed, 151 insertions(+), 46 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/18116/1
--
To view, visit http://gerrit.cloudera.org:8080/18116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie75e246f924fe96d1d8f0f0a54511c810851f56c
Gerrit-Change-Number: 18116
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <[email protected]>

Reply via email to