Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18114 )
Change subject: KUDU-3346: fix rebalancer tool fails to run with '--ignored_tservers' ...................................................................... KUDU-3346: fix rebalancer tool fails to run with '--ignored_tservers' Prior to this patch the validity of 'ignored_tservers' was checked when 'BuildClusterinfo', which leads to a failure when the 'raw_info' only contains contains information of tservers on a specific location. This patch fix it by moving the parameter validity check into 'KsckResultsToClusterRawInfo', because ksck results contain original cluster information. I noticed 'ClusterInfo::tservers_to_empty' is not necessary to be built when 'BuildClusterInfo', because we use this info only for printing cluster's stats and running IgnoredTserverRunner. This should be refactored in follow-up patch. This patch adds a regression test for the issue and I also verified this fix on a real cluster. Change-Id: I1361f562f3e886077a79c3de8ea5fb2ebb8df6e9 Reviewed-on: http://gerrit.cloudera.org:8080/18114 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Andrew Wong <[email protected]> --- M src/kudu/rebalance/rebalancer.cc M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/tools/rebalancer_tool.cc M src/kudu/tools/rebalancer_tool.h 4 files changed, 151 insertions(+), 46 deletions(-) Approvals: Andrew Wong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1361f562f3e886077a79c3de8ea5fb2ebb8df6e9 Gerrit-Change-Number: 18114 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]>
