Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18149 )
Change subject: [tests] make DisableWriteWhenExceedingQuotaTest more stable
......................................................................
[tests] make DisableWriteWhenExceedingQuotaTest more stable
I noticed that the TestDisableWritePrivilegeWhenExceedingSizeQuota
scenario of from DisableWriteWhenExceedingQuotaTest test failed when
running pre-commit checks [1] for one code review item [2] with the
error output below:
src/kudu/integration-tests/write_limit-itest.cc:229: Failure
Value of: s.IsIOError()
Actual: false
Expected: true
OK
src/kudu/integration-tests/write_limit-itest.cc:423: Failure
Expected: TestSizeLimit() doesn't generate new fatal failures in the current
thread.
Actual: it does.
I took a look at the scenario and modified the disk size limit a bit,
adding an extra comment for the disk size limit.
Running the modified test didn't show any signs of flakiness [3].
[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1642105466.1969358
[2] https://gerrit.cloudera.org/#/c/18147/
[3] http://dist-test.cloudera.org/job?job_id=aserbin.1642137803.81044
Change-Id: I58530d4b79da43d17b504b09abb3741fa16a936f
Reviewed-on: http://gerrit.cloudera.org:8080/18149
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Andrew Wong <[email protected]>
---
M src/kudu/integration-tests/write_limit-itest.cc
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58530d4b79da43d17b504b09abb3741fa16a936f
Gerrit-Change-Number: 18149
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
