Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18149 )
Change subject: [tests] make DisableWriteWhenExceedingQuotaTest more stable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18149/1/src/kudu/integration-tests/write_limit-itest.cc File src/kudu/integration-tests/write_limit-itest.cc: http://gerrit.cloudera.org:8080/#/c/18149/1/src/kudu/integration-tests/write_limit-itest.cc@426 PS1, Line 426: 1024 * (1024 + 110) > I'm surprised a difference of only ~10KB makes the difference, though I gue That's not so straightforward as it seems :) Reducing the size further (especially drastically) brakes the test. With 110 --> 64 change it starts breaking every time when trying to re-insert a single row after removing all the rows inserted prior. With 110 --> 80 it breaks every 4-th time or so. I guess the overall scenario could be implemented to be more stable in that regard, but I don't want to waste time doing so. -- To view, visit http://gerrit.cloudera.org:8080/18149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58530d4b79da43d17b504b09abb3741fa16a936f Gerrit-Change-Number: 18149 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Jan 2022 15:26:11 +0000 Gerrit-HasComments: Yes
