Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18158 )
Change subject: [docs] update Transaction Semantics page ...................................................................... Patch Set 1: Code-Review+1 (7 comments) http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc File docs/transaction_semantics.adoc: http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@102 PS1, Line 102: are not fully Atomic nit: maybe, add more color here to be something like ... are not fully Atomic unless they are part of a multi-tablet write transaction http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@169 PS1, Line 169: described above nit: maybe, drop this since there is already 'described above' in the end of the sentence http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@174 PS1, Line 174: multiple clients per transaction Maybe, add an extra paragraph to mention that instead of passing around transaction ID a serialized transaction handle is passed around enabling multiple clients residing at different nodes to participate in the same transaction. http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@188 PS1, Line 188: operations have succeeded (i.e. did not return row errors) before committing. Does it make sense to mention how deadlocks are resolved in the scope of multi-row transactions? http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@191 PS1, Line 191: Kudu nit: Kudu cluster http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@192 PS1, Line 192: If multiple clients are expected to write to a single : transaction, rather than heartbeating from each client, the heartbeating can be disabled with the : following calls when deserializing a new transaction handle: IIRC, the default setting for the heartbeating is off, meaning a new transaction handle created out of a serialized handle produced with default serialization option is not going to send out heartbeat messages. http://gerrit.cloudera.org:8080/#/c/18158/1/docs/transaction_semantics.adoc@283 PS1, Line 283: are not currently supported nit: does it make sense to clarify that's so even for a transactional session itself, i.e. while in a multi-row transaction it's not possible to have read-your-writes semantics? -- To view, visit http://gerrit.cloudera.org:8080/18158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03554b8b7b497e962f30bf1c84f9c033af4a85c1 Gerrit-Change-Number: 18158 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 19 Jan 2022 18:32:19 +0000 Gerrit-HasComments: Yes
